refactor: Clean Architecture 적용 및 코드베이스 전면 리팩토링
## 주요 변경사항 ### 아키텍처 개선 - Clean Architecture 패턴 적용 (Domain, Data, Presentation 레이어 분리) - Use Case 패턴 도입으로 비즈니스 로직 캡슐화 - Repository 패턴으로 데이터 접근 추상화 - 의존성 주입 구조 개선 ### 상태 관리 최적화 - 모든 Controller에서 불필요한 상태 관리 로직 제거 - 페이지네이션 로직 통일 및 간소화 - 에러 처리 로직 개선 (에러 메시지 한글화) - 로딩 상태 관리 최적화 ### Mock 서비스 제거 - MockDataService 완전 제거 - 모든 화면을 실제 API 전용으로 전환 - 불필요한 Mock 관련 코드 정리 ### UI/UX 개선 - Overview 화면 대시보드 기능 강화 - 라이선스 만료 알림 위젯 추가 - 사이드바 네비게이션 개선 - 일관된 UI 컴포넌트 사용 ### 코드 품질 - 중복 코드 제거 및 함수 추출 - 파일별 책임 분리 명확화 - 테스트 코드 업데이트 ## 영향 범위 - 모든 화면의 Controller 리팩토링 - API 통신 레이어 구조 개선 - 에러 처리 및 로깅 시스템 개선 ## 향후 계획 - 단위 테스트 커버리지 확대 - 통합 테스트 시나리오 추가 - 성능 모니터링 도구 통합
This commit is contained in:
JiWoong Sul
231
test/domain/usecases/auth/login_usecase_test.dart
Normal file
231
test/domain/usecases/auth/login_usecase_test.dart
Normal file
@@ -0,0 +1,231 @@
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:mockito/mockito.dart';
|
||||
import 'package:mockito/annotations.dart';
|
||||
import 'package:dartz/dartz.dart';
|
||||
import 'package:dio/dio.dart';
|
||||
import 'package:superport/domain/usecases/auth/login_usecase.dart';
|
||||
import 'package:superport/domain/usecases/base_usecase.dart';
|
||||
import 'package:superport/services/auth_service.dart';
|
||||
import 'package:superport/data/models/auth/login_request.dart';
|
||||
import 'package:superport/data/models/auth/login_response.dart';
|
||||
import 'package:superport/data/models/auth/auth_user.dart';
|
||||
import 'package:superport/core/utils/error_handler.dart';
|
||||
|
||||
import 'login_usecase_test.mocks.dart';
|
||||
|
||||
@GenerateMocks([AuthService])
|
||||
void main() {
|
||||
late LoginUseCase loginUseCase;
|
||||
late MockAuthService mockAuthService;
|
||||
|
||||
setUp(() {
|
||||
mockAuthService = MockAuthService();
|
||||
loginUseCase = LoginUseCase(mockAuthService);
|
||||
});
|
||||
|
||||
group('LoginUseCase', () {
|
||||
const tEmail = 'test@example.com';
|
||||
const tPassword = 'password123!';
|
||||
const tInvalidEmail = 'invalid-email';
|
||||
const tEmptyPassword = '';
|
||||
|
||||
final tLoginRequest = LoginRequest(
|
||||
email: tEmail,
|
||||
password: tPassword,
|
||||
);
|
||||
|
||||
final tLoginResponse = LoginResponse(
|
||||
accessToken: 'test_access_token',
|
||||
refreshToken: 'test_refresh_token',
|
||||
tokenType: 'Bearer',
|
||||
expiresIn: 3600,
|
||||
user: AuthUser(
|
||||
id: 1,
|
||||
username: 'testuser',
|
||||
email: tEmail,
|
||||
name: 'Test User',
|
||||
role: 'U',
|
||||
),
|
||||
);
|
||||
|
||||
test('로그인 성공 시 Right(LoginResponse) 반환', () async {
|
||||
// arrange
|
||||
when(mockAuthService.login(any))
|
||||
.thenAnswer((_) async => tLoginResponse);
|
||||
|
||||
// act
|
||||
final result = await loginUseCase(
|
||||
LoginParams(email: tEmail, password: tPassword),
|
||||
);
|
||||
|
||||
// assert
|
||||
expect(result, Right(tLoginResponse));
|
||||
verify(mockAuthService.login(argThat(
|
||||
predicate<LoginRequest>((req) =>
|
||||
req.email == tEmail && req.password == tPassword),
|
||||
))).called(1);
|
||||
verifyNoMoreInteractions(mockAuthService);
|
||||
});
|
||||
|
||||
test('잘못된 이메일 형식 입력 시 ValidationFailure 반환', () async {
|
||||
// act
|
||||
final result = await loginUseCase(
|
||||
LoginParams(email: tInvalidEmail, password: tPassword),
|
||||
);
|
||||
|
||||
// assert
|
||||
expect(result.isLeft(), true);
|
||||
result.fold(
|
||||
(failure) {
|
||||
expect(failure, isA<AppFailure>());
|
||||
expect(failure.message, '올바른 이메일 형식이 아닙니다.');
|
||||
},
|
||||
(_) => fail('Should return failure'),
|
||||
);
|
||||
verifyNever(mockAuthService.login(any));
|
||||
});
|
||||
|
||||
test('빈 비밀번호 입력 시 ValidationFailure 반환', () async {
|
||||
// act
|
||||
final result = await loginUseCase(
|
||||
LoginParams(email: tEmail, password: tEmptyPassword),
|
||||
);
|
||||
|
||||
// assert
|
||||
expect(result.isLeft(), true);
|
||||
result.fold(
|
||||
(failure) {
|
||||
expect(failure, isA<AppFailure>());
|
||||
expect(failure.message, '비밀번호를 입력해주세요.');
|
||||
},
|
||||
(_) => fail('Should return failure'),
|
||||
);
|
||||
verifyNever(mockAuthService.login(any));
|
||||
});
|
||||
|
||||
test('401 에러 시 AuthFailure 반환', () async {
|
||||
// arrange
|
||||
final dioError = DioException(
|
||||
requestOptions: RequestOptions(path: '/login'),
|
||||
response: Response(
|
||||
requestOptions: RequestOptions(path: '/login'),
|
||||
statusCode: 401,
|
||||
),
|
||||
type: DioExceptionType.badResponse,
|
||||
);
|
||||
|
||||
when(mockAuthService.login(any)).thenThrow(dioError);
|
||||
|
||||
// act
|
||||
final result = await loginUseCase(
|
||||
LoginParams(email: tEmail, password: tPassword),
|
||||
);
|
||||
|
||||
// assert
|
||||
expect(result.isLeft(), true);
|
||||
result.fold(
|
||||
(failure) {
|
||||
expect(failure, isA<AppFailure>());
|
||||
expect(failure.message, contains('인증'));
|
||||
},
|
||||
(_) => fail('Should return failure'),
|
||||
);
|
||||
});
|
||||
|
||||
test('네트워크 타임아웃 시 NetworkFailure 반환', () async {
|
||||
// arrange
|
||||
final dioError = DioException(
|
||||
requestOptions: RequestOptions(path: '/login'),
|
||||
type: DioExceptionType.connectionTimeout,
|
||||
);
|
||||
|
||||
when(mockAuthService.login(any)).thenThrow(dioError);
|
||||
|
||||
// act
|
||||
final result = await loginUseCase(
|
||||
LoginParams(email: tEmail, password: tPassword),
|
||||
);
|
||||
|
||||
// assert
|
||||
expect(result.isLeft(), true);
|
||||
result.fold(
|
||||
(failure) {
|
||||
expect(failure, isA<AppFailure>());
|
||||
expect(failure.message, contains('네트워크'));
|
||||
},
|
||||
(_) => fail('Should return failure'),
|
||||
);
|
||||
});
|
||||
|
||||
test('서버 에러 시 ServerFailure 반환', () async {
|
||||
// arrange
|
||||
final dioError = DioException(
|
||||
requestOptions: RequestOptions(path: '/login'),
|
||||
response: Response(
|
||||
requestOptions: RequestOptions(path: '/login'),
|
||||
statusCode: 500,
|
||||
data: {'message': '서버 내부 오류'},
|
||||
),
|
||||
type: DioExceptionType.badResponse,
|
||||
);
|
||||
|
||||
when(mockAuthService.login(any)).thenThrow(dioError);
|
||||
|
||||
// act
|
||||
final result = await loginUseCase(
|
||||
LoginParams(email: tEmail, password: tPassword),
|
||||
);
|
||||
|
||||
// assert
|
||||
expect(result.isLeft(), true);
|
||||
result.fold(
|
||||
(failure) {
|
||||
expect(failure, isA<AppFailure>());
|
||||
expect(failure.message, contains('서버'));
|
||||
},
|
||||
(_) => fail('Should return failure'),
|
||||
);
|
||||
});
|
||||
|
||||
test('예상치 못한 에러 시 UnknownFailure 반환', () async {
|
||||
// arrange
|
||||
when(mockAuthService.login(any))
|
||||
.thenThrow(Exception('Unexpected error'));
|
||||
|
||||
// act
|
||||
final result = await loginUseCase(
|
||||
LoginParams(email: tEmail, password: tPassword),
|
||||
);
|
||||
|
||||
// assert
|
||||
expect(result.isLeft(), true);
|
||||
result.fold(
|
||||
(failure) {
|
||||
expect(failure, isA<AppFailure>());
|
||||
expect(failure.message, contains('오류'));
|
||||
},
|
||||
(_) => fail('Should return failure'),
|
||||
);
|
||||
});
|
||||
|
||||
test('로그인 실패 시 (null 반환) AuthFailure 반환', () async {
|
||||
// arrange
|
||||
when(mockAuthService.login(any)).thenAnswer((_) async => null);
|
||||
|
||||
// act
|
||||
final result = await loginUseCase(
|
||||
LoginParams(email: tEmail, password: tPassword),
|
||||
);
|
||||
|
||||
// assert
|
||||
expect(result.isLeft(), true);
|
||||
result.fold(
|
||||
(failure) {
|
||||
expect(failure, isA<AppFailure>());
|
||||
expect(failure.message, contains('로그인'));
|
||||
},
|
||||
(_) => fail('Should return failure'),
|
||||
);
|
||||
});
|
||||
});
|
||||
}
|
||||
153
test/domain/usecases/auth/login_usecase_test.mocks.dart
Normal file
153
test/domain/usecases/auth/login_usecase_test.mocks.dart
Normal file
@@ -0,0 +1,153 @@
|
||||
// Mocks generated by Mockito 5.4.5 from annotations
|
||||
// in superport/test/domain/usecases/auth/login_usecase_test.dart.
|
||||
// Do not manually edit this file.
|
||||
|
||||
// ignore_for_file: no_leading_underscores_for_library_prefixes
|
||||
import 'dart:async' as _i4;
|
||||
|
||||
import 'package:dartz/dartz.dart' as _i2;
|
||||
import 'package:mockito/mockito.dart' as _i1;
|
||||
import 'package:superport/core/errors/failures.dart' as _i5;
|
||||
import 'package:superport/data/models/auth/auth_user.dart' as _i9;
|
||||
import 'package:superport/data/models/auth/login_request.dart' as _i7;
|
||||
import 'package:superport/data/models/auth/login_response.dart' as _i6;
|
||||
import 'package:superport/data/models/auth/token_response.dart' as _i8;
|
||||
import 'package:superport/services/auth_service.dart' as _i3;
|
||||
|
||||
// ignore_for_file: type=lint
|
||||
// ignore_for_file: avoid_redundant_argument_values
|
||||
// ignore_for_file: avoid_setters_without_getters
|
||||
// ignore_for_file: comment_references
|
||||
// ignore_for_file: deprecated_member_use
|
||||
// ignore_for_file: deprecated_member_use_from_same_package
|
||||
// ignore_for_file: implementation_imports
|
||||
// ignore_for_file: invalid_use_of_visible_for_testing_member
|
||||
// ignore_for_file: must_be_immutable
|
||||
// ignore_for_file: prefer_const_constructors
|
||||
// ignore_for_file: unnecessary_parenthesis
|
||||
// ignore_for_file: camel_case_types
|
||||
// ignore_for_file: subtype_of_sealed_class
|
||||
|
||||
class _FakeEither_0<L, R> extends _i1.SmartFake implements _i2.Either<L, R> {
|
||||
_FakeEither_0(
|
||||
Object parent,
|
||||
Invocation parentInvocation,
|
||||
) : super(
|
||||
parent,
|
||||
parentInvocation,
|
||||
);
|
||||
}
|
||||
|
||||
/// A class which mocks [AuthService].
|
||||
///
|
||||
/// See the documentation for Mockito's code generation for more information.
|
||||
class MockAuthService extends _i1.Mock implements _i3.AuthService {
|
||||
MockAuthService() {
|
||||
_i1.throwOnMissingStub(this);
|
||||
}
|
||||
|
||||
@override
|
||||
_i4.Stream<bool> get authStateChanges => (super.noSuchMethod(
|
||||
Invocation.getter(#authStateChanges),
|
||||
returnValue: _i4.Stream<bool>.empty(),
|
||||
) as _i4.Stream<bool>);
|
||||
|
||||
@override
|
||||
_i4.Future<_i2.Either<_i5.Failure, _i6.LoginResponse>> login(
|
||||
_i7.LoginRequest? request) =>
|
||||
(super.noSuchMethod(
|
||||
Invocation.method(
|
||||
#login,
|
||||
[request],
|
||||
),
|
||||
returnValue:
|
||||
_i4.Future<_i2.Either<_i5.Failure, _i6.LoginResponse>>.value(
|
||||
_FakeEither_0<_i5.Failure, _i6.LoginResponse>(
|
||||
this,
|
||||
Invocation.method(
|
||||
#login,
|
||||
[request],
|
||||
),
|
||||
)),
|
||||
) as _i4.Future<_i2.Either<_i5.Failure, _i6.LoginResponse>>);
|
||||
|
||||
@override
|
||||
_i4.Future<_i2.Either<_i5.Failure, void>> logout() => (super.noSuchMethod(
|
||||
Invocation.method(
|
||||
#logout,
|
||||
[],
|
||||
),
|
||||
returnValue: _i4.Future<_i2.Either<_i5.Failure, void>>.value(
|
||||
_FakeEither_0<_i5.Failure, void>(
|
||||
this,
|
||||
Invocation.method(
|
||||
#logout,
|
||||
[],
|
||||
),
|
||||
)),
|
||||
) as _i4.Future<_i2.Either<_i5.Failure, void>>);
|
||||
|
||||
@override
|
||||
_i4.Future<_i2.Either<_i5.Failure, _i8.TokenResponse>> refreshToken() =>
|
||||
(super.noSuchMethod(
|
||||
Invocation.method(
|
||||
#refreshToken,
|
||||
[],
|
||||
),
|
||||
returnValue:
|
||||
_i4.Future<_i2.Either<_i5.Failure, _i8.TokenResponse>>.value(
|
||||
_FakeEither_0<_i5.Failure, _i8.TokenResponse>(
|
||||
this,
|
||||
Invocation.method(
|
||||
#refreshToken,
|
||||
[],
|
||||
),
|
||||
)),
|
||||
) as _i4.Future<_i2.Either<_i5.Failure, _i8.TokenResponse>>);
|
||||
|
||||
@override
|
||||
_i4.Future<bool> isLoggedIn() => (super.noSuchMethod(
|
||||
Invocation.method(
|
||||
#isLoggedIn,
|
||||
[],
|
||||
),
|
||||
returnValue: _i4.Future<bool>.value(false),
|
||||
) as _i4.Future<bool>);
|
||||
|
||||
@override
|
||||
_i4.Future<_i9.AuthUser?> getCurrentUser() => (super.noSuchMethod(
|
||||
Invocation.method(
|
||||
#getCurrentUser,
|
||||
[],
|
||||
),
|
||||
returnValue: _i4.Future<_i9.AuthUser?>.value(),
|
||||
) as _i4.Future<_i9.AuthUser?>);
|
||||
|
||||
@override
|
||||
_i4.Future<String?> getAccessToken() => (super.noSuchMethod(
|
||||
Invocation.method(
|
||||
#getAccessToken,
|
||||
[],
|
||||
),
|
||||
returnValue: _i4.Future<String?>.value(),
|
||||
) as _i4.Future<String?>);
|
||||
|
||||
@override
|
||||
_i4.Future<String?> getRefreshToken() => (super.noSuchMethod(
|
||||
Invocation.method(
|
||||
#getRefreshToken,
|
||||
[],
|
||||
),
|
||||
returnValue: _i4.Future<String?>.value(),
|
||||
) as _i4.Future<String?>);
|
||||
|
||||
@override
|
||||
_i4.Future<void> clearSession() => (super.noSuchMethod(
|
||||
Invocation.method(
|
||||
#clearSession,
|
||||
[],
|
||||
),
|
||||
returnValue: _i4.Future<void>.value(),
|
||||
returnValueForMissingStub: _i4.Future<void>.value(),
|
||||
) as _i4.Future<void>);
|
||||
}
|
||||
Reference in New Issue
Block a user