julian/superport_v2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(dialog): 상세 팝업 SuperportDetailDialog 통합

Browse Source 
- SuperportDetailDialog 위젯과 showSuperportDetailDialog 헬퍼를 추가하고 metadata/섹션 패턴을 표준화

- 결재/재고/마스터 각 상세 다이얼로그를 dialogs 디렉터리에 신설하고 기존 페이지를 신규 팝업으로 전환

- SuperportTable 행 선택과 우편번호 검색 다이얼로그 onRowTap 보정을 통해 헤더 오프셋 버그를 제거

- 상세 다이얼로그 및 트랜잭션/상세 뷰 전용 위젯 테스트와 tester_extensions 유틸을 추가하여 회귀를 방지

- detail_dialog_unification_plan.md로 작업 배경과 필드 통합 계획을 문서화
This commit is contained in:
JiWoong Sul
2025-11-07 19:02:43 +09:00
parent 1f78171294
commit 2f8b529506
64 changed files with 13721 additions and 7545 deletions
Download Patch File Download Diff File Expand all files Collapse all files

282
test/features/approvals/template/presentation/dialogs/approval_template_detail_dialog_test.dart Normal file
View File

@@ -0,0 +1,282 @@
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:get_it/get_it.dart';
import 'package:intl/intl.dart' as intl;
import 'package:shadcn_ui/shadcn_ui.dart';
import 'package:superport_v2/core/services/token_storage.dart';
import 'package:superport_v2/features/approvals/domain/entities/approval_template.dart';
import 'package:superport_v2/features/approvals/template/presentation/dialogs/approval_template_detail_dialog.dart';
import 'package:superport_v2/features/auth/application/auth_service.dart';
import 'package:superport_v2/features/auth/domain/entities/auth_session.dart';
import 'package:superport_v2/features/auth/domain/entities/authenticated_user.dart';
import 'package:superport_v2/features/auth/domain/entities/login_request.dart';
import 'package:superport_v2/features/auth/domain/repositories/auth_repository.dart';
import 'package:superport_v2/widgets/components/superport_detail_dialog.dart';
import '../../../../../helpers/test_app.dart';
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
final dateFormat = intl.DateFormat('yyyy-MM-dd HH:mm');
late ApprovalTemplate sampleTemplate;
late ApprovalTemplateApprover approver1;
late ApprovalTemplateApprover approver2;
setUp(() {
final getIt = GetIt.I;
if (!getIt.isRegistered<AuthService>()) {
getIt.registerSingleton<AuthService>(
_StubAuthService(
AuthSession(
accessToken: 'access',
refreshToken: 'refresh',
expiresAt: DateTime.now().add(const Duration(hours: 1)),
user: const AuthenticatedUser(
id: 1,
name: '테스터',
employeeNo: 'E001',
),
permissions: const [],
),
),
);
}
approver1 = ApprovalTemplateApprover(
id: 501,
employeeNo: 'E501',
name: '1차 승인자',
);
approver2 = ApprovalTemplateApprover(
id: 502,
employeeNo: 'E502',
name: '2차 승인자',
);
sampleTemplate = ApprovalTemplate(
id: 10,
code: 'TEMP-10',
name: '자산 구매 결재',
description: '자산 구매 시 사용하는 기본 결재선',
note: '월별로 재검토 필요',
isActive: true,
createdAt: DateTime(2024, 1, 1, 9),
updatedAt: DateTime(2024, 1, 10, 10),
steps: [
ApprovalTemplateStep(
id: 1001,
stepOrder: 1,
approver: approver1,
note: '팀 리더 확인',
),
ApprovalTemplateStep(
id: 1002,
stepOrder: 2,
approver: approver2,
note: '경영진 승인',
),
],
);
});
tearDown(() {
final getIt = GetIt.I;
if (getIt.isRegistered<AuthService>()) {
getIt.unregister<AuthService>();
}
});
testWidgets('템플릿 상세 다이얼로그는 요약과 메타데이터를 info panel에 표시한다', (tester) async {
await tester.pumpWidget(buildTestApp(const SizedBox.shrink()));
final context = tester.element(find.byType(SizedBox));
final resultFuture = showApprovalTemplateDetailDialog(
context: context,
dateFormat: dateFormat,
template: sampleTemplate,
onCreate: (_, __) => Future.value(null),
onUpdate: (_, __, ___) => Future.value(sampleTemplate),
onDelete: (_) => Future.value(false),
onRestore: (_) => Future.value(null),
);
await tester.pump();
await tester.pump(const Duration(milliseconds: 100));
expect(find.text('결재 템플릿 상세'), findsAtLeastNWidgets(1));
expect(find.text(sampleTemplate.name), findsAtLeastNWidgets(1));
expect(find.text('단계'), findsOneWidget);
expect(find.text('코드'), findsWidgets);
expect(find.text('TEMP-10'), findsWidgets);
expect(find.text('상태'), findsWidgets);
expect(find.text('생성일시'), findsWidgets);
expect(find.byType(SuperportDetailDialog), findsOneWidget);
await tester.tap(find.byTooltip('닫기'), warnIfMissed: false);
await tester.pump(const Duration(milliseconds: 100));
expect(await resultFuture, isNull);
});
testWidgets('생성 모드에서 필수 정보를 입력하면 onCreate 콜백이 호출된다', (tester) async {
final createdTemplates = <ApprovalTemplateInput>[];
final createdSteps = <List<ApprovalTemplateStepInput>>[];
await tester.pumpWidget(buildTestApp(const SizedBox.shrink()));
final context = tester.element(find.byType(SizedBox));
final resultFuture = showApprovalTemplateDetailDialog(
context: context,
dateFormat: dateFormat,
template: null,
onCreate: (input, steps) async {
createdTemplates.add(input);
createdSteps.add(steps);
return sampleTemplate.copyWith(name: input.name);
},
onUpdate: (_, __, ___) => Future.value(null),
onDelete: (_) => Future.value(false),
onRestore: (_) => Future.value(null),
);
await tester.pump();
await tester.pumpAndSettle();
await tester.enterText(
find.byKey(const ValueKey('template_form_name')),
'신규 결재 템플릿',
);
await tester.enterText(
find.byKey(const ValueKey('template_step_0_order')),
'1',
);
final approverFieldFinder = find.byKey(
const ValueKey('template_step_0_approver'),
);
final approverFieldState = tester.state(approverFieldFinder) as dynamic;
approverFieldState.widget.idController.text = approver1.id.toString();
await tester.pump();
final submitButton = tester.widget<ShadButton>(
find.widgetWithText(ShadButton, '등록'),
);
expect(submitButton.onPressed, isNotNull);
submitButton.onPressed!();
await tester.pump();
await tester.pumpAndSettle();
expect(createdTemplates, isNotEmpty);
final result = await resultFuture;
expect(result, isNotNull);
expect(result!.action, ApprovalTemplateDetailAction.created);
expect(createdTemplates, hasLength(1));
expect(createdTemplates.first.name, '신규 결재 템플릿');
expect(createdSteps.single.first.approverId, approver1.id);
});
testWidgets('삭제 탭에서 삭제 버튼을 누르면 onDelete 콜백이 호출되어 결과가 반환된다', (tester) async {
var deleteCalled = false;
await tester.pumpWidget(buildTestApp(const SizedBox.shrink()));
final context = tester.element(find.byType(SizedBox));
final resultFuture = showApprovalTemplateDetailDialog(
context: context,
dateFormat: dateFormat,
template: sampleTemplate,
onCreate: (_, __) => Future.value(null),
onUpdate: (_, __, ___) => Future.value(sampleTemplate),
onDelete: (_) async {
deleteCalled = true;
return true;
},
onRestore: (_) => Future.value(null),
);
await tester.pump();
await tester.pumpAndSettle();
final tabsFinder = find.descendant(
of: find.byType(SuperportDetailDialog),
matching: find.byType(ShadTabs<String>),
);
final tabsState = tester.state(tabsFinder);
final controller =
(tabsState as dynamic).controller as ShadTabsController<String>;
controller.select('delete');
await tester.pump(const Duration(milliseconds: 100));
final deleteButtonFinder = find.byWidgetPredicate(
(widget) =>
widget is ShadButton &&
widget.variant == ShadButtonVariant.destructive &&
widget.child is Text &&
(widget.child as Text).data == '삭제',
);
expect(deleteButtonFinder, findsOneWidget);
final deleteButton = tester.widget<ShadButton>(deleteButtonFinder);
expect(deleteButton.onPressed, isNotNull);
deleteButton.onPressed!();
await tester.pump();
await tester.pump(const Duration(milliseconds: 100));
final result = await resultFuture;
expect(deleteCalled, isTrue);
expect(result, isNotNull);
expect(result!.action, ApprovalTemplateDetailAction.deleted);
});
}
class _StubAuthService extends AuthService {
_StubAuthService(this._session)
: super(
repository: _FakeAuthRepository(),
tokenStorage: _FakeTokenStorage(),
);
final AuthSession _session;
@override
AuthSession? get session => _session;
}
class _FakeAuthRepository implements AuthRepository {
@override
Future<AuthSession> login(LoginRequest request) {
throw UnimplementedError();
}
@override
Future<AuthSession> refresh(String refreshToken) {
throw UnimplementedError();
}
}
class _FakeTokenStorage implements TokenStorage {
String? access;
String? refresh;
@override
Future<void> clear() async {
access = null;
refresh = null;
}
@override
Future<String?> readAccessToken() async => access;
@override
Future<String?> readRefreshToken() async => refresh;
@override
Future<void> writeAccessToken(String? token) async {
access = token;
}
@override
Future<void> writeRefreshToken(String? token) async {
refresh = token;
}
}

90
test/features/approvals/template/presentation/pages/approval_template_page_test.dart
View File

@@ -14,6 +14,7 @@ import 'package:superport_v2/features/approvals/domain/usecases/save_approval_te
import 'package:superport_v2/features/approvals/template/presentation/pages/approval_template_page.dart';
import 'package:superport_v2/features/approvals/shared/domain/entities/approval_approver_candidate.dart';
import 'package:superport_v2/features/approvals/shared/domain/repositories/approval_approver_repository.dart';
import 'package:superport_v2/features/approvals/shared/widgets/approver_autocomplete_field.dart';
import 'package:superport_v2/features/auth/application/auth_service.dart';
import 'package:superport_v2/features/auth/domain/entities/auth_session.dart';
import 'package:superport_v2/features/auth/domain/entities/authenticated_user.dart';
@@ -169,8 +170,8 @@ void main() {
await tester.pump();
await tester.pumpAndSettle();
expect(find.text('AP_INBOUND'), findsOneWidget);
expect(find.text('입고 템플릿'), findsOneWidget);
expect(find.text('AP_INBOUND'), findsWidgets);
expect(find.text('입고 템플릿'), findsWidgets);
expect(find.textContaining('1. 최승인'), findsOneWidget);
verify(
@@ -198,7 +199,7 @@ void main() {
when(
() => repository.create(any(), steps: any(named: 'steps')),
).thenAnswer((_) async => buildTemplate());
).thenAnswer((_) async => buildTemplate().copyWith(name: '신규 템플릿'));
await tester.pumpWidget(_buildApp(const ApprovalTemplatePage()));
await tester.pump();
@@ -207,43 +208,26 @@ void main() {
await tester.tap(find.text('템플릿 생성'));
await tester.pumpAndSettle();
final dialogFieldsFinder = find.descendant(
of: find.byType(Dialog),
matching: find.byType(EditableText),
skipOffstage: false,
);
final dialogFieldElements = dialogFieldsFinder.evaluate().toList();
expect(dialogFieldElements.length, greaterThanOrEqualTo(4));
await tester.enterText(
find.byWidget(dialogFieldElements[0].widget),
'AP_NEW',
);
await tester.enterText(
find.byWidget(dialogFieldElements[1].widget),
find.byKey(const ValueKey('template_form_name')),
'신규 템플릿',
);
final stepFieldsFinder = find.descendant(
of: find.byKey(const ValueKey('step_field_0')),
matching: find.byType(EditableText),
skipOffstage: false,
final approverField = tester.widget<ApprovalApproverAutocompleteField>(
find.byType(ApprovalApproverAutocompleteField).first,
);
final stepFieldElements = stepFieldsFinder.evaluate().toList();
expect(stepFieldElements.length, greaterThanOrEqualTo(2));
await tester.enterText(find.byWidget(stepFieldElements[1].widget), '33');
await tester.testTextInput.receiveAction(TextInputAction.done);
approverField.idController.text = '33';
await tester.pump();
await tester.tap(find.text('생성 완료'));
final createButtonFinder = find.widgetWithText(ShadButton, '등록').last;
final createButton = tester.widget<ShadButton>(createButtonFinder);
createButton.onPressed?.call();
await tester.pump();
await tester.pumpAndSettle();
verify(
() => repository.create(any(), steps: any(named: 'steps')),
).called(1);
expect(find.text('템플릿 "신규 템플릿"을 생성했습니다.'), findsOneWidget);
expect(find.textContaining('템플릿 "신규 템플릿"'), findsOneWidget);
});
testWidgets('보기 버튼을 눌러 템플릿 단계를 미리본다', (tester) async {
@@ -273,25 +257,25 @@ void main() {
await tester.pump();
await tester.pumpAndSettle();
final previewFinder = find.text('보기', skipOffstage: false);
await tester.dragUntilVisible(
previewFinder,
find.text(template.name),
const Offset(-200, 0),
);
await tester.pumpAndSettle();
await tester.tap(previewFinder);
await tester.tap(find.text(template.name));
await tester.pump();
await tester.pumpAndSettle();
expect(find.text(template.name), findsWidgets);
final detailTabsState =
tester.state(find.byWidgetPredicate((widget) => widget is ShadTabs))
as dynamic;
detailTabsState.controller.select('steps');
await tester.pump();
await tester.pumpAndSettle();
expect(find.textContaining('사번 E001'), findsOneWidget);
verify(
() => repository.fetchDetail(template.id, includeSteps: true),
).called(1);
await tester.tap(find.byTooltip('닫기'));
await tester.pumpAndSettle();
});
testWidgets('수정 플로우에서 fetchDetail 후 update를 호출한다', (tester) async {
@@ -334,31 +318,25 @@ void main() {
repository.list(page: 1, pageSize: 20, query: null, isActive: null),
).called(1);
await tester.dragUntilVisible(
find.text('수정'),
find.text('입고 템플릿'),
const Offset(-200, 0),
);
await tester.pumpAndSettle();
await tester.tap(find.text('수정').first);
await tester.tap(find.text('입고 템플릿'));
await tester.pump();
await tester.pumpAndSettle();
final editDialogFields = find.descendant(
of: find.byType(Dialog),
matching: find.byType(EditableText),
skipOffstage: false,
);
final editFieldElements = editDialogFields.evaluate().toList();
expect(editFieldElements.length, greaterThanOrEqualTo(1));
final tabsState =
tester.state(find.byWidgetPredicate((widget) => widget is ShadTabs))
as dynamic;
tabsState.controller.select('edit');
await tester.pump();
await tester.pumpAndSettle();
await tester.enterText(
find.byWidget(editFieldElements[0].widget),
find.byKey(const ValueKey('template_form_name')),
'수정된 템플릿',
);
await tester.tap(find.text('수정 완료'));
final saveButtonFinder = find.widgetWithText(ShadButton, '저장').last;
final saveButton = tester.widget<ShadButton>(saveButtonFinder);
saveButton.onPressed?.call();
await tester.pump();
await tester.pumpAndSettle();
@@ -367,7 +345,7 @@ void main() {
() => repository.update(10, any(), steps: any(named: 'steps')),
).called(1);
expect(find.text('템플릿 "입고 템플릿"을(를) 수정했습니다.'), findsOneWidget);
expect(find.text('템플릿 "수정된 템플릿"을(를) 수정했습니다.'), findsOneWidget);
});
});
}